Fabiano Neves's profileFabiano Neves Amorim - S...PhotosBlogListsMore Tools Help

Blog


    October 26

    Cuidado com o IF EXISTS…

    Aqui estou em Buenos Aires trabalhando na otimização de algumas rotinas…. e fica uma dica rápida,

    Pessoal quando criarem código SQL, tentem pensar como o banco de dados, por exemplo, cuidado com instruções do tipo:


      WHILE @CD_Cota <= @NO_Maximo_Cota
      BEGIN
        IF NOT EXISTS (SELECT ID_Cota
                         FROM CONVE002 (NOLOCK)
                        WHERE CD_Cota  = @CD_Cota
                          AND ID_Grupo = @ID_Grupo
                          AND Versao = 0)
        AND ((@ST_Reserva = 'T') OR (dbo.fn_VeSNCotaReservada(@ID_Grupo, @CD_Cota, @DT_Base) = @ST_Reserva))

        BEGIN
          SET @ST_Reserva_Cota = dbo.fn_VeSNCotaReservada(@ID_Grupo, @CD_Cota, @DT_Base)

          INSERT INTO @tb_Reserva (ID_Grupo,
                                   CD_Grupo,
                                   CD_Cota,
                                   ST_Reserva)
          VALUES (@ID_Grupo,
                  @CD_Grupo,
                  @CD_Cota,
                  @ST_Reserva_Cota)
        END

        SET @CD_Cota = @CD_Cota + 1;
      END

    Ou seja, para validar este IF, o SQL vai terá que ler a tabela CONVE002, depois vai ler o resultado da fn_VeSN… para resolver o EXISTS e depois vai ler denovo a fn_VeSN….

    Isso funciona bem quando estamos falando de C# ou Pascal, mas como estamos falando de banco, o Ideal seriamos utilizar várias instruções de IF. Por ex:

    WHILE @CD_Cota <= @NO_Maximo_Cota
    BEGIN
      IF NOT EXISTS (SELECT ID_Cota
                       FROM CONVE002 (NOLOCK)
                      WHERE CD_Cota  = @CD_Cota
                        AND ID_Grupo = @ID_Grupo
                        AND Versao = 0)
      BEGIN
        IF (@ST_Reserva = 'T')
        BEGIN
          INSERT INTO @tb_Reserva (ID_Grupo,
                                   CD_Grupo,
                                   CD_Cota,
                                   ST_Reserva)
          VALUES (@ID_Grupo,
                  @CD_Grupo,
                  @CD_Cota,
                  @ST_Reserva_Cota)
        END
        ELSE
        BEGIN
          SET @ST_Reserva_Cota = dbo.fn_VeSNCotaReservada(@ID_Grupo, @CD_Cota, @DT_Base);
          IF (@ST_Reserva_Cota = @ST_Reserva)
          BEGIN
            INSERT INTO @tb_Reserva (ID_Grupo,
                                     CD_Grupo,
                                     CD_Cota,
                                     ST_Reserva)
            VALUES (@ID_Grupo,
                    @CD_Grupo,
                    @CD_Cota,
                    @ST_Reserva_Cota)
          END
        END
      END   

      SET @CD_Cota = @CD_Cota + 1;
    END

    Ou seja, removemos o disperdicio …

    Comments

    Please wait...
    Sorry, the comment you entered is too long. Please shorten it.
    You didn't enter anything. Please try again.
    Sorry, we can't add your comment right now. Please try again later.
    To add a comment, you need permission from your parent. Ask for permission
    Your parent has turned off comments.
    Sorry, we can't delete your comment right now. Please try again later.
    You've exceeded the maximum number of comments that can be left in one day. Please try again in 24 hours.
    Your account has had the ability to leave comments disabled because our systems indicate that you may be spamming other users. If you believe that your account has been disabled in error please contact Windows Live support.
    Complete the security check below to finish leaving your comment.
    The characters you type in the security check must match the characters in the picture or audio.

    To add a comment, sign in with your Windows Live ID (if you use Hotmail, Messenger, or Xbox LIVE, you have a Windows Live ID). Sign in


    Don't have a Windows Live ID? Sign up

    Trackbacks

    The trackback URL for this entry is:
    http://fabianosqlserver.spaces.live.com/blog/cns!52EFF7477E74CAA6!1692.trak
    Weblogs that reference this entry
    • None